Use default in-memory keystore for commands that don't use keystore #4634

NikVolf · 2020-01-15T16:35:17Z

Probably as a workaround until better refactoring

client/cli/src/lib.rs

tomusdrw

Looks good, but would be really good to add some simple tests that actually execute the CLI to prevent issues like this in the future.

bkchr · 2020-01-16T09:09:55Z

@tomusdrw I'm with you, but I think we should do this in a separate PR. (updated the issue)

NikVolf added the A0-please_review Pull request needs code review. label Jan 15, 2020

NikVolf changed the title ~~Use default in-memory for commands that don't use keystore~~ Use default in-memory keystore for commands that don't use keystore Jan 15, 2020

bkchr approved these changes Jan 16, 2020

View reviewed changes

client/cli/src/lib.rs Outdated Show resolved Hide resolved

use default in-memory for commands that don't use keystore

b0bec0d

NikVolf force-pushed the nv-fix-keystore-cfg branch from 4c29436 to b0bec0d Compare January 16, 2020 07:59

tomusdrw reviewed Jan 16, 2020

View reviewed changes

bkchr merged commit 4c4ee3d into master Jan 16, 2020

bkchr deleted the nv-fix-keystore-cfg branch January 16, 2020 09:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use default in-memory keystore for commands that don't use keystore #4634

Use default in-memory keystore for commands that don't use keystore #4634

NikVolf commented Jan 15, 2020 •

edited by bkchr

Loading

tomusdrw left a comment •

edited

Loading

bkchr commented Jan 16, 2020 •

edited

Loading

Use default in-memory keystore for commands that don't use keystore #4634

Use default in-memory keystore for commands that don't use keystore #4634

Conversation

NikVolf commented Jan 15, 2020 • edited by bkchr Loading

tomusdrw left a comment • edited Loading

Choose a reason for hiding this comment

bkchr commented Jan 16, 2020 • edited Loading

NikVolf commented Jan 15, 2020 •

edited by bkchr

Loading

tomusdrw left a comment •

edited

Loading

bkchr commented Jan 16, 2020 •

edited

Loading